[DTOSS-13125] -Extract assign-arc-app-roles into a dedicated make target - #132
Merged
josielsouzanordcloud merged 1 commit intoJun 10, 2026
Merged
Conversation
Separates `assign_arc_app_roles.sh` from `resource-group-init` into its own `assign-arc-app-roles` make target, as the two operations have different lifecycles — bootstrap runs once per environment, while app role assignment must be re-run each time a new Arc machine is onboarded. Updates onboard-hospital-vm.md to reorder steps so Grant API access (Step 3) comes before Trigger Terraform (Step 4), matching the end-to-end deployment diagram. Also corrects the prerequisites checklist to reflect that the SPN secret is generated fresh with a 1-day expiry rather than retrieved from Key Vault.
floormind
approved these changes
Jun 10, 2026
steventux
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts
assign_arc_app_roles.shfrom theresource-group-initmake target into its ownassign-arc-app-rolestarget. The two operations have different lifecycles:resource-group-initis a one-time environment bootstrap, whereas app role assignment must be re-run each time a new Arc machine is onboarded.Reorders the onboarding runbook so Grant API access (Step 3) comes before Trigger Terraform (Step 4).
Corrects the prerequisites checklist to reflect that the SPN secret is generated fresh with a 1-day expiry rather than retrieved from Key Vault.
Test plan
make <env> resource-group-initruns the Bicep bootstrap only (no app role assignment)make <env> assign-arc-app-rolesassigns theGateway.Accessrole to Arc machine managed identitiesJira link
DTOSS-13125
Review notes
Review checklist